Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update helm flag in docs for enableWeightChangesDynamicReload #5313

Merged
merged 2 commits into from
Mar 26, 2024
Merged

update helm flag in docs for enableWeightChangesDynamicReload #5313

merged 2 commits into from
Mar 26, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner March 26, 2024 16:19
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Mar 26, 2024
@j1m-ryan j1m-ryan requested a review from a team as a code owner March 26, 2024 16:30
@j1m-ryan j1m-ryan enabled auto-merge (squash) March 26, 2024 16:39
@j1m-ryan j1m-ryan merged commit 0651f25 into main Mar 26, 2024
53 checks passed
@j1m-ryan j1m-ryan deleted the docs/dynamic-reload-flag-fix branch March 26, 2024 17:16
j1m-ryan added a commit that referenced this pull request Mar 26, 2024
@j1m-ryan
update helm flag in docs for enableWeightChangesDynamicReload (#5313)
eb71d37 
* update helm flag in docs

* add flag to installation-with-helm file
j1m-ryan added a commit that referenced this pull request Mar 27, 2024
@j1m-ryan
Cherry Pick: update helm flag in docs for enableWeightChangesDynamicR…
0423aa0 
…eload (#5313) (#5315)

update helm flag in docs for enableWeightChangesDynamicReload (#5313)

* update helm flag in docs

* add flag to installation-with-helm file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j1m-ryan @oseoin @vepatel